Report descriptions - #8
Open
AntonieV wants to merge 40 commits into
Open
Conversation
…and for fingerprint and profile plot and for heatmap
…ach antibody, adaptations for snakemake workflow catalog, more plot descriptions for report, cleanup configs, README and ToDo's
dlaehnemann
reviewed
Jun 25, 2021
dlaehnemann
left a comment
dlaehnemann
left a comment
Member
There was a problem hiding this comment.
Great work, thanks a bunch!
I did not manage to go through everything, yet, but wanted to at least release this batch of comments. I should be approximately half way through...
dlaehnemann
reviewed
Jun 28, 2021
dlaehnemann
requested changes
Jun 28, 2021
dlaehnemann
left a comment
dlaehnemann
left a comment
Member
There was a problem hiding this comment.
Once again, great work. And some more suggestions on the second half of this pull request. This is looking really good. We just have to clean up a bit more and we'll finally have that exemplary reimplementation of a nextflow workflow! 🎉
Collaborator
Author
|
Thank you very much for the review and the many great suggestions! |
dlaehnemann
reviewed
Jan 21, 2022
dlaehnemann
left a comment
dlaehnemann
left a comment
Member
There was a problem hiding this comment.
Thanks again for this major effort. And here finally comes my review. This all looks very good, and any remaining suggestions are either just formatting to improve readability or wording changes to make the report even clearer. Just two actual questions, I think. So we're almost done!
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Collaborator
Author
|
Thank you very much for reviewing the PR and the great and helpful suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description for plots used in report added, changes on deseq2 for comparisons of samples across the groups from each antibody, adaptations for snakemake workflow catalog, cleanup configs, README and ToDo's